Warrior Forum - The #1 Digital Marketing Forum & Marketplace

Warrior Forum - The #1 Digital Marketing Forum & Marketplace (https://www.warriorforum.com/)
-   Programming (https://www.warriorforum.com/programming/)
-   -   Security Advice Needed (https://www.warriorforum.com/programming/752168-security-advice-needed.html)

Kirk Ward 10th February 2013 07:07 PM

Security Advice Needed
 
I am creating a wordpress multiser or network site with forms on each blogs dashboard where the admin can enter content.

There are two textare boxes and one text input box in the form and it is being saved as post metadata using a _POST action.

What would you suggest I use to sanitize the data that is being saved? And, where would this sanitizing function go?

Thanks,

SteveSRS 11th February 2013 02:29 AM

Re: Security Advice Needed
 
Check out PDO it auto sanitizes (when used correctly!!)

Kirk Ward 11th February 2013 07:36 AM

Re: Security Advice Needed
 
Being one old non-coder, PDO looks to be way over my head.

I was reading the Wordpress Codex for update_post() and noted that it runs any submission through kses. Does update_meta() run data submitted through kses?

SteveJohnson 11th February 2013 08:51 AM

Re: Security Advice Needed
 
This page: Data Validation « WordPress Codex discusses data validation in WP. There are a number of WP functions that will do what you need. Also, you should check the docs on WP nonces: WordPress Nonces « WordPress Codex. Your form processing function verifies the nonce to ensure that whatever submitted the form data has the authority to do so.

Also, it sounds like you're trying to create a dashboard widget? If so, this page: Dashboard Widgets API « WordPress Codex might help.

Quote:

Does update_meta() run data submitted through kses?
No, it does not. The only sanitization of data occurs when the UPDATE statement is prepared. You need to do your own validation first.

Kirk Ward 18th February 2013 09:09 PM

Re: Security Advice Needed
 
Thanks Steve,

I've been struggling, trying to figure out what to do and am wondering if I could create a function and have the sanitize_meta function clean up things for me. Seems that is called when the update_meta function is called.

What you think?

SteveJohnson 19th February 2013 12:24 AM

Re: Security Advice Needed
 
The sanitize_meta function is just an empty hook, it doesn't do anything on its own. You build your own sanitizing filter (function) for a specific meta key, and run it by adding the filter to the sanitize_meta function. You would use this kind of filter most often when you're needing to validate/sanitize a custom field that a user would enter.

In your case, it would be easier to just build your filter into the function that saves the meta data.

Let's say you want to allow only the limited HTML that is allowed in a comment. It's as simple as this:

$meta_data = wp_kses_data( $_POST['meta_data'] );
update_post_meta( $post->ID, 'meta_key', $meta_data );

( Function Reference/wp kses data « WordPress Codex )

It's kind of difficult to guide you without seeing exactly what you're doing.

lordspace 19th February 2013 06:20 PM

Re: Security Advice Needed
 
For my fields I use strip_tags and trim to make sure HTML tags are removed.
Is it text content that goes in the text fields?

SteveSRS 20th February 2013 01:34 AM

Re: Security Advice Needed
 
lordspace that is def not enough for insertion in a database...

SteveJohnson 20th February 2013 10:10 AM

Re: Security Advice Needed
 
Quote:

Originally Posted by SteveSRS (Post 7761876)
lordspace that is def not enough for insertion in a database...

It is if you're using built-in WP routines to update the db, as Kirk is.

Kirk Ward 20th February 2013 11:28 PM

Re: Security Advice Needed
 
Quote:

Originally Posted by SteveJohnson (Post 7757260)
t's kind of difficult to guide you without seeing exactly what you're doing.

Sorry I've not answered sooner. I've been trying to understand Stripe (http://stripe.com)

I tried posting my code in here, but it appears I can't do the bbcode for code.

Okay if I PM you and send what I think is the pertinent code either privately or in an email?

I'm not sure whether to put the sanitize function in the functions.php or the include file. Take a look at the code and you'll see why ... one of the things I do is switch between blogs a bit.

Kirk Ward 20th February 2013 11:30 PM

Re: Security Advice Needed
 
Quote:

Originally Posted by lordspace (Post 7760743)
For my fields I use strip_tags and trim to make sure HTML tags are removed.
Is it text content that goes in the text fields?

Yes, it is text only for two textarea fields and numberic only for the text input box.

numberic?

I need to learn to spell when it is four hours past my old geezer bedtime.

SteveJohnson 21st February 2013 11:46 AM

Re: Security Advice Needed
 
Quote:

Originally Posted by Kirk Ward (Post 7766646)
Sorry I've not answered sooner. I've been trying to understand Stripe (http://stripe.com)

I tried posting my code in here, but it appears I can't do the bbcode for code.

Okay if I PM you and send what I think is the pertinent code either privately or in an email?

I'm not sure whether to put the sanitize function in the functions.php or the include file. Take a look at the code and you'll see why ... one of the things I do is switch between blogs a bit.

Would be better if you were to supply the complete plugin or theme folder that you're working on, that lets me see everything in context. Just zip up the folder and send it in a pm to me (I think you can include files in PMs? Dunno for sure). I'll PM you my email addr to use if that won't work.

Kirk Ward 21st February 2013 06:49 PM

Re: Security Advice Needed
 
Quote:

Originally Posted by SteveJohnson (Post 7769044)
Would be better if you were to supply the complete plugin or theme folder that you're working on, that lets me see everything in context. Just zip up the folder and send it in a pm to me (I think you can include files in PMs? Dunno for sure). I'll PM you my email addr to use if that won't work.

I'd thank you two or three times if the WF software would let me.

Files sent.


All times are GMT -6. The time now is 11:46 PM.